Bug #42 - Modernize support for various MacOS APIs to their 10.5 equivalents.
Google user: azanar
What steps will reproduce the problem?
1. Open synergy.xcode
2. Set SDK being used to MacOS 10.5 SDK
3. Watch the deprecation warnings pile up.
This is the text of the patch I submitted to the synergy project; hopefully
it proves useful here as well:
This patch modernizes synergy's MacOS support to the 10.5 SDK. The primary
goal was to eliminate warnings due to deprecated API calls. Specifics
include:
- Shifting from Scrap Manager to Pasteboard Manager for transferring
clipboard contents - Using Text Input Services API instead of Keyboard Layout API for
determining appropriate key/character mappings. - Removing support for deprecated KCHR resources.
- Shifting to CoreGraphics from Display Manager for figuring screen
geometry on screen resolution change events.
Note that these warnings do not appear when building against the latest
synergy release; it uses the MacOS 10.2.8 SDK by default, which does not
deprecate these calls. Eventually, though, that SDK will be obsoleted, and
removed from the developer tools, at which point these changes will
hopefully prove quite useful. :-)
Notes on testing and style are appreciated.
#1
Google user: tbowman
where did you locate the synergy.xcode file from? it doesn't appear to be in the svn
repository for synergy-plus
#3
Google user: azanar
The synergy.xcode "file" (it's really a directory that the MacOS UI treats as a file)
exists within the original synergy CVS repository.
You're right to point out it doesn't exist within the svn repo here , but what does
exist is a hardcoding of the 10.2 API within configure.in. I can change that as well,
and submit a revised patch a little bit later on this evening. :-)
#4
Google user: tescott425
Looking forward to the update. I've tried running synergy (not synergy+) with a
WinXP machine set up as a server and a Mac OSX 10.5.6 as a client. It works ok, but
there are few issues I've encountered:
option keys tend to toggle instead of "press and hold" as I'd expect. Have to do a
workaround for hooking up IBOutlets when using the iPhone SDK.the numpad keys don't appear to be transmitting as NUMPAD_SLASH, etc. At least, a
program that I'm using doesn't recognize them as such. It *does* recognize the local
keyboard when the NUMPAD keys are being used.have to implement a workaround to keep synergyc running. Otherwise, it dies.
#5
Google user: azanar
Attached a new patch to fix up configure.in to go looking for the OS 10.5 SDK.
#6
Google user: azanar
tescott425,
There is a patch on the old synergy project for this problem. It is unrelated to the
10.5 changes I made, and instead has to do with making API calls after a vfork. If I
have time in the next little bit, I'll see about posting that patch as a separate
ticket here.
As for the other two issues, I don't believe this patch addresses those either. I
might be pleasantly surprised to learn that it does. They both strike me as matters
of character map confusion. It might not hurt to throw these into a separate issue,
just so they are easier to track versus this patch. :-)
#7
Google user: tescott425
I tried applying the patch after getting the latest copy of code via svn. I've never
used patch before so maybe I'm doing something wrong, but here's the result of doing
"patch < synergy.10.5.patch" which indicates a problem:
patching file configure.in
can't find file to patch at input line 18
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
|Index: lib/platform/COSXClipboardTextConverter.h
|===================================================================
|--- lib/platform/COSXClipboardTextConverter.h ("/p/synergy-plus/source/detail?r=897":revision 897 )
|+++ lib/platform/COSXClipboardTextConverter.h (working copy)
File to patch:
#8
Google user: azanar
Use "patch -p 0 < synergy.10.5.patch" from the root of the svn checkout.
Not using -p causes patch(1) to just use the basename of each file to be patched. Man
page for patch(1) points this out explicitly.
#9
Google user: sorin.sbarnea
I did the integration after a successful test.
#10
Google user: sorin.sbarnea
We'll keep this bug open because current code doesn't compile with 10.6 SDK. We need
to make the code compatible with 10.5 and 10.6.
Azanar, can you take a look at 10.6 issues?
#11
Google user: tbowman
I'm new to mac development tools. What are the exact tools/sdk's needed for compiling
the latest source on a x86 leopard install. with xcode 3.1 and 10.5 sdk + patches i'm
still seeing several compile errors.
#12
Google user: sorin.sbarnea
Our target is to make it build and run with 10.5 and 10.6 using current Apple build
tools. I can confirm that current code doesn't build yet with 10.6 but with 10.5 it
should work.
As I do not have enough time now for this please feel free to try to solve issues
(even partially) and attach a patch. It will be much easier to find some time to test
and integrate the patch.
#13
Google user: azanar
sorin: I'd need to get my hands on a OS 10.6 SDK seed at least, and probably a seed
of the OS to test it. These are expensive, and I am unable, and don't expect that too
many people are able either, to part with the money required to make this happen.
Maybe someone else lurking on the list here has an ADC account?
tbowman: if you can post your compile logs here or to a new ticket -- your call --, I
can probably at least give an overview of what appears to be going on.
#14
Google user: twentyafterfour
when compiling on 10.5 I get a build that is not very functional. Most of the keys on
my keyboard don't transfer, even between two os x 10.5 machines. Only the cursor keys
appear to work when I run the latest code compiled on 10.5 (as a server) and even
worse, if I run the latest client then none of the keys work.
I had to change a couple of lines of code to make it compile. I can get it to compile
now with either command-line make or with xcode, either way I get keys not working.
#16
Google user: edw...@carrel.org
twentyafterfour: Are you using a non-standard keyboard layout? Any other
utilities/haxies/etc. you have that might have that are capturing keyboard input?
Also, can you let me know which lines you had to change to get the code to build?
#18
Google user: nick.bolton.uk
What is the status of this issue? Did the patch work?
#19
Google user: edw...@carrel.org
Not sure. I still have a bit set to go examine all the various patched files within
our svn repo and make sure the changes that I passed in as patches made it in.
That we got an issue report for a problem my patch caused, and then started kind of
bouncing back and forth between the two tickets...yeah. Not so good.
#20
Google user: snes350
I think this came up again with 10.6. I started trying to change to the newer
functions in the file COSXScreen.cpp. I only changed two functions so far out of
what looks like a handful. I get some weird behavior with right clicks in XCode
highlighting one character to the right at the same time as the click, click and drag
selection not working until the click is released, and outside of XCode,
double-clicks don't highlight text. I'm hoping these will go away if I update the
rest of the functions that need updating.
Write comment