Feature #38 - Better communcation messages
Google user: gbonvehi
I was trying this new version of synergy, great work!
I compiled latest svn version on linux and windows, it's working perfectly.
I've a suggestion to improve synergy a little bit, I saw in the source that
you send whole messages like CNOP in the packets, I did a little
modification to use only one character per message and seems to be working
fine.
I'm attaching the modifications in case you'd like to improve this, there
are other things that may be improved, like synergy sending tons of
malformed packets (you can see that using wireshark).
Thanks for the effort! Oh, and you may want to add to INSTALL file that you
have to run autoreconf --install --force to recreate the ./configure file
when downloading from SVN.
Thanks,
Guillermo Bonvehi
#1
Google user: gbonvehi
This should be an Enhancement, sorry about that.
#2
Google user: gbonvehi
Found a minor glitch, if you apply this patch, line 143 in file CClientProxy10.cpp
should be:
LOG((CLOGDEBUG2 "msg from \"%%s\": %%c", getName().c_str(), code[0]));
#3
Google user: gbonvehi
Added another patch, this one avoids using memcmp by comparing directly the first
char on the array. Maybe it should check for NULL too.
This patch includes the glitch I found earlier in the other patch and other I forgot
on CServerProxy.cpp.
#5
Google user: syed.a...@gilani.eu
Won't this make it incompatible with older versions? If so there should be a fallback
to the old format.
#6
Google user: gbonvehi
Indeed, it will make it incompatible with older versions. However, if this
enhancement is accepted, during negotiation it could decide which version of the
protocol it has to use.
#9
Google user: nick.bolton.uk
Guillermo: I'm sorry to see your patch hasn't been applied to our code base yet. I'm
sure you can understand that since it's such a large patch it takes a lot of time to
review. We really appreciate your effort.
I think that the code you submitted may be useful for the issue #5 fix, where Sorin
aims to restructure the way keystrokes are sent from the server, which is scheduled
for milestone M2. Not too sure if these two issues are related though so please feel
free to call me out if I'm way off base.
Please feel welcome to submit further patches, and we'll do our best to incorporate
them into our milestone efforts.
#11
Google user: gbonvehi
Nick: I'm glad you like the changes I made. It doesn't matter if you apply it or not,
maybe you can find a better way to do this as I'm not a C/C++ expert.
I took a quick look at Issue #5 but I don't think they're related, this just shortens
the message that's sent/received.
If I find any other thing to improve I'll send a patch or let you know.
Thanks for the effort you make on Synergy, it's a very useful program.
Write comment